Messages in this thread | | | Date | Wed, 17 Dec 2014 16:39:58 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH 2/2] mm: hugetlb: fix type of hugetlb_treat_as_movable variable |
| |
On Wed, 17 Dec 2014, Andrey Ryabinin wrote:
> hugetlb_treat_as_movable declared as unsigned long, but > proc_dointvec() used for parsing it: > > static struct ctl_table vm_table[] = { > ... > { > .procname = "hugepages_treat_as_movable", > .data = &hugepages_treat_as_movable, > .maxlen = sizeof(int), > .mode = 0644, > .proc_handler = proc_dointvec, > }, > > This seems harmless, but it's better to use int type here. > > Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
Acked-by: David Rientjes <rientjes@google.com>
| |