Messages in this thread | | | Subject | Re: [PATCH] Staging: unisys: virtpci: fixed some coding style issues | From | Joe Perches <> | Date | Wed, 17 Dec 2014 15:38:25 -0800 |
| |
On Wed, 2014-12-17 at 15:27 -0800, Andrew Milkovich wrote: > Fixed some coding style issues
This is not a very descriptive subject or commit log message. Please describe what changes are being done.
> diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c [] > @@ -279,9 +279,9 @@ static int add_vbus(struct add_vbus_guestpart *addparams) > POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR); > return 0; > } > - write_vbus_chp_info(vbus->platform_data /* chanptr */ , > + write_vbus_chp_info(vbus->platform_data /* chanptr */, > &chipset_driver_info);
I think it better to just remove the comments like:
write_vbus_chp_info(vbus->platform_data, &chipset_driver_info);
> @@ -466,7 +466,7 @@ static int pause_vhba(struct pause_virt_guestpart *pauseparams) > GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams->chanptr); > > LOGINF("Pausing vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2); > - i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE, > + i = virtpci_device_serverdown(NULL /*no parent bus */, VIRTHBA_TYPE, > &scsi.wwnn, NULL);
i = vittpci_device_serverdown(NULL, VIRTHBA_TYPE, &scsi.wwnn, NULL);
etc.
| |