Messages in this thread | | | Date | Wed, 17 Dec 2014 09:04:52 +0100 | Subject | Re: [PATCH] i2c: sh_mobile: I2C_SH_MOBILE should depend on HAS_DMA | From | Geert Uytterhoeven <> |
| |
Hi Wolfram,
On Wed, Dec 17, 2014 at 7:58 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> drivers/built-in.o: In function `sh_mobile_i2c_dma_unmap': >> i2c-sh_mobile.c:(.text+0x60de42): undefined reference to `dma_unmap_single' >> drivers/built-in.o: In function `sh_mobile_i2c_xfer_dma': >> i2c-sh_mobile.c:(.text+0x60df22): undefined reference to `dma_map_single' >> i2c-sh_mobile.c:(.text+0x60df2e): undefined reference to `dma_mapping_error' >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Thanks for spotting this. However, since DMA is opt-in, isn't this > dependency too much? I can't think of anything better than #ifdeffing > the code, though.
You're right.
E.g. drivers/spi/spi.c (in SPI the mapping is handled by the core), this code is #ifdefed out.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |