Messages in this thread | | | Date | Thu, 18 Dec 2014 02:07:56 +0800 | From | Tsung-Han Lin <> | Subject | Re: [PATCH] staging:board: fix build errors and warnings |
| |
On Fri, Dec 12, 2014 at 11:36:10AM +0000, Grant Likely wrote: > On Tue, 9 Dec 2014 01:24:09 +0800 > , Tsung-Han Lin <tsunghan.tw@gmail.com> > wrote: > > Add dummy implementation of 'of_find_all_nodes', > > and remove the unnecessary 'of_can_translate_address', > > which is already removed in commit > > d9c6866be8a145e32da616d8dcbae806032d75b5 ("of: kill off > > of_can_translate_address"), to fix the build errors and warnings > > found by sparse. > > > > Signed-off-by: Tsung-Han Lin <tsunghan.tw@gmail.com> > > ??? > > This code is just weird. If CONFIG_OF is not enabled, then board.c > shouldn't be compiled at all. You can do this with a patch to the > Kconfig and Makefile. Also, if the functions in > drivers/staging/board/board.c are needed for driver support, then please > propose a patch that moves them in into drivers/of/base.c so that they > can be reviewed properly. They are so short and simple that fixing them > up as part of the normal review process should be sufficient. > > As for fixing the compile error, please drop the change to > include/linux/of.h and resubmit. > > g. > >
Sorry it took me sometime to understand what I got wrong, and thank you for your suggestion. I will re-send a fix for this.
I just built those codes with wrong .config and options.
| |