Messages in this thread | | | From | Alexandre Courbot <> | Date | Wed, 17 Dec 2014 16:51:04 +0900 | Subject | Re: [PATCH v2 1/4] gpio: dln2: fix issue when an IRQ is unmasked then enabled |
| |
On Wed, Dec 17, 2014 at 12:57 AM, Octavian Purdila <octavian.purdila@intel.com> wrote: > As noticed during suspend/resume operations, the IRQ can be unmasked > then disabled in suspend and eventually enabled in resume, but without > being unmasked. > > The current implementation does not take into account interactions > between mask/unmask and enable/disable interrupts, and thus in the > above scenarios the IRQs remain unactive. > > To fix this we removed the enable/disable operations as they fallback > to mask/unmask anyway. > > We also remove the pending bitmaks as it is already done in irq_data > (i.e. IRQS_PENDING). > > Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> > --- > drivers/gpio/gpio-dln2.c | 53 +++++++----------------------------------------- > 1 file changed, 7 insertions(+), 46 deletions(-)
Yum, less code!
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
| |