lkml.org 
[lkml]   [2014]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block
On 12/08/2014 04:22 PM, Bjorn Andersson wrote:

> +
> +Optional properties:
> +- label: The label for this led
> + See Documentation/devicetree/bindings/leds/common.txt
> +- linux,default-trigger: Default trigger assigned to the LED
> + See Documentation/devicetree/bindings/leds/common.txt
> +- qcom,cs-out: bool; enable current sink output
> +- qcom,cabc: bool; enable content adaptive backlight control
> +- qcom,ext-gen: bool; use externally generated modulator signal to dim
> +- qcom,current-limit: mA; per-string current limit; value from 0 to 25
> + default: 20mA
> +- qcom,current-boost-limit: mA; boost current limit; one of:
> + 105, 385, 525, 805, 980, 1260, 1400, 1680
> + default: 805mA
> +- qcom,switching-freq: kHz; switching frequency; one of:
> + 600, 640, 685, 738, 800, 872, 960, 1066, 1200, 1371,
> + 1600, 1920, 2400, 3200, 4800, 9600,
> + default: 1600kHz
> +- qcom,ovp: V; Over-voltage protection limit; one of:
> + 27, 29, 32, 35
> + default: 29V

It would be nice if the units were part of the property name, i.e.
qcom,ovp-V, qcom,current-boost-limit-mA, etc. That way the units are
known without having to refer to the documentation.

> +- qcom,num-strings: #; number of led strings attached; value from 1 to 3
> + default: 2

I wonder if qcom,#strings is more appropriate?

> +
> +Example:
> +
> +pm8941-wled@d800 {
> + compatible = "qcom,pm8941-wled";
> + reg = <0xd800>;
> + label = "backlight";
> +
> + qcom,cs-out;
> + qcom,current-limit = <20>;
> + qcom,current-boost-limit = <805>;
> + qcom,switching-freq = <1600>;
> + qcom,ovp = <29>;
> + qcom,num-strings = <2>;
> +};


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project



\
 
 \ /
  Last update: 2014-12-17 02:41    [W:0.096 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site