lkml.org 
[lkml]   [2014]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
Hello Thomas,

On Tue, Dec 16, 2014 at 05:01:38PM +0100, Thomas Petazzoni wrote:
> Dear Evgeni Dobrev,
>
> On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> > This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
>
> Commit log text should be wrapped to some reasonable length.
>

I will fix this.

>
> > interrupts = <21>;
> > clocks = <&gate_clk 14>, <&gate_clk 15>;
> > clock-names = "0", "1";
> > + phys = <&sata_phy0>, <&sata_phy1>;
> > + phy-names = "port0", "port1";
>
> You should use tabs and not spaces for indentation in Device Tree files.

I will resubmit. Thank you for your review.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> --

evgeni


\
 
 \ /
  Last update: 2014-12-16 20:01    [W:0.074 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site