| Date | Tue, 16 Dec 2014 18:47:17 +0200 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH 01/18] x86/uaccess: fix sparse errors |
| |
On Sun, Dec 14, 2014 at 06:51:57PM +0200, Michael S. Tsirkin wrote: > virtio wants to read bitwise types from userspace using get_user. At the > moment this triggers sparse errors, since the value is passed through an > integer. > > Fix that up using __force. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > ---
Ping. Do x86 maintainers consider fixing sparse errors applicable for 3.19? If yes, can you pls merge this patch?
> arch/x86/include/asm/uaccess.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h > index 0d592e0..8ce1af8 100644 > --- a/arch/x86/include/asm/uaccess.h > +++ b/arch/x86/include/asm/uaccess.h > @@ -179,7 +179,7 @@ __typeof__(__builtin_choose_expr(sizeof(x) > sizeof(0UL), 0ULL, 0UL)) > asm volatile("call __get_user_%P3" \ > : "=a" (__ret_gu), "=r" (__val_gu) \ > : "0" (ptr), "i" (sizeof(*(ptr)))); \ > - (x) = (__typeof__(*(ptr))) __val_gu; \ > + (x) = (__force __typeof__(*(ptr))) __val_gu; \ > __ret_gu; \ > }) > > -- > MST >
|