Messages in this thread | | | Date | Tue, 16 Dec 2014 14:51:00 +0000 | From | David Vrabel <> | Subject | Re: [Xen-devel] [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols |
| |
On 15/12/14 11:47, Jan Beulich wrote: >>>> On 15.12.14 at 12:38, <david.vrabel@citrix.com> wrote: >> On 11/12/14 18:04, Juergen Gross wrote: >>> --- a/arch/x86/syscalls/Makefile >>> +++ b/arch/x86/syscalls/Makefile >> >> Why are these changes here and not in arch/x86/xen/Makefile? > > Because this needs to be done in a step that (afaict) has no hook > in the Xen-specific Makefile. > >>> @@ -47,10 +50,16 @@ $(out)/syscalls_32.h: $(syscall32) $(systbl) >>> $(out)/syscalls_64.h: $(syscall64) $(systbl) >>> $(call if_changed,systbl) >>> >>> +$(out)/xen-hypercalls.h: $(srctree)/scripts/xen-hypercalls.sh >>> + $(call if_changed,hypercalls) >>> + >>> +$(out)/xen-hypercalls.h: $(srctree)/include/xen/interface/xen*.h >> >> The generated header should end up in asm/xen/ > > Why is generated/asm/ not good enough?
I meant something like generated/asm/xen/hypercall-macros.h
So a "xen/" prefix which is consistent with all the other xen specific headers.
But if this is non-trivial it's not a major issue.
David
| |