Messages in this thread | | | Date | Tue, 16 Dec 2014 10:09:57 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH v2] VERIFY_OCTAL_PERMISSIONS: Move to <linux/sysfs.h> where it belongs |
| |
Hi George,
On Mon, 15 Dec 2014 14:26:15 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote: > > George Spelvin <linux@horizon.com> writes: > > It's the only user of <linux/bug.h> in kernel.h, so that reduces > > the compile-time cost of #include <linux/kernel.h> > > > > Only one user has to change: <linux/moduleparam.h>. The <linux/types.h> > > there is needed for one function prototype that passes s16 parameters. > > My first reaction is to wonder if that can be gotten rid of, too. > > > > Some other extraneous header files pruned while I was at it. > > Tested with allyesconfig & allmodconfig on x86-64, just to > > be sure.
Please do *not* mix changes up like this. Split this out into a separate patch, please (1 logical change per patch). And testing only on x86_64 is not "sure" when talking about header file pruning (but at least you did the "all" configs).
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au [unhandled content-type:application/pgp-signature] | |