Messages in this thread | | | Date | Mon, 15 Dec 2014 07:49:20 -0500 | Subject | Re: [PATCH 1/8] nfs: follow direct I/O write locking convention | From | Trond Myklebust <> |
| |
On Mon, Dec 15, 2014 at 12:26 AM, Omar Sandoval <osandov@osandov.com> wrote: > The generic callers of direct_IO lock i_mutex before doing a write. NFS > doesn't use the generic write code, so it doesn't follow this > convention. This is now a problem because the interface introduced for > swap-over-NFS calls direct_IO for a write without holding i_mutex, but > other implementations of direct_IO will expect to have it locked.
I really don't care much about swap-over-NFS performance; that's a niche usage at best. I _do_ care about O_DIRECT performance, and the ability to run multiple WRITE calls in parallel.
IOW: Patch NACKed... Please find another solution.
Trond
| |