Messages in this thread | | | Subject | Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions | From | peterhuewe@gmx ... | Date | Sun, 14 Dec 2014 16:31:10 +0100 |
| |
On 14. Dezember 2014 15:57:10 MEZ, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: >On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote: >> On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote: >> > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c. >> > Added "tpm_" prefix for consistency sake. Changed cmd parameter as >> > opaque. This enables to use separate command structures for TPM1 >> > and TPM2 commands in future. Loose coupling works fine here. >> > >> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> >> > Reviewed-by: Jasob Gunthorpe <jason.gunthorpe@obsidianresearch.com> >> > Reviewed-by: Stephan Berger <stephan.berger@linux.vnet.ibm.com> >> >> Not quite ... Stefan Berger <stefanb@linux.vnet.ibm.com> > >Oops. Peter, I guess you could fix those or? My apologies. > >> Stefan > >/Jarkko I'll fix this, No problem. Peter -- Sent from my mobile.
| |