lkml.org 
[lkml]   [2014]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ASoC: codecs: wm8904: add dt ids table
Hi Mark,

On 12/12/2014 09:23 PM, Mark Brown wrote:
> On Thu, Dec 11, 2014 at 11:14:39AM +0800, Bo Shen wrote:
>
>> +static const struct of_device_id wm8904_of_match[] = {
>> + { .compatible = "wlf,wm8904", },
>> + { .compatible = "wlf,wm8912", },
>> + { .compatible = "wlf,wm8918", },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, wm8904_of_match);
>> +
>> static struct i2c_driver wm8904_i2c_driver = {
>> .driver = {
>> .name = "wm8904",
>> .owner = THIS_MODULE,
>> + .of_match_table = wm8904_of_match,
>
> I'm not seeing anything here that ensures that devtype is set correctly
> when probing using the OF IDs - currently we rely on i2c->driver_data.
>

I will add it in v2 patch.
Thanks.

Best Regards,
Bo Shen


\
 
 \ /
  Last update: 2014-12-15 05:01    [W:0.052 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site