Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 0/2] Properly fix sysfs_get_idlestate_count() | Date | Sun, 14 Dec 2014 22:30:17 +0100 |
| |
On Sunday, December 14, 2014 09:06:36 AM Prarit Bhargava wrote: > My previous commit 16b7c275c055 ("tools: cpupower: fix return checks for > sysfs_get_idlestate_count()") was not correct. After looking > at the changelog for cpupower I noticed that Thomas had changed the return of > sysfs_get_idlestate_count() to an unsigned int to simplify the code. The > problem is really that both he (in his original change) and I (in my new > change) missed the obvious that sysfs_get_idlestate_count() > can't return -ENODEV. It should just return 0 for "no c-states". > > Patch 1 reverts my recent change and patch 2 fixes the problem correctly. > > Sorry 'bout that Thomas. I should have caught that the the first time. > > Cc: Thomas Renninger <trenn@suse.de> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > > Prarit Bhargava (2): > Revert "tools: cpupower: fix return checks for > sysfs_get_idlestate_count()" > Fix no idle state information return value > > tools/power/cpupower/utils/cpuidle-info.c | 8 ++++---- > tools/power/cpupower/utils/helpers/sysfs.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-)
I'll queue up the revert, but I need an ACK from Thomas for the second patch.
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |