Messages in this thread | | | Date | Sun, 14 Dec 2014 10:05:43 +0100 | Subject | Re: [PATCH 2/2] Input: gpio_keys - replace timer and workqueue with delayed workqueue | From | Linus Walleij <> |
| |
On Mon, Dec 8, 2014 at 8:21 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> We do not need to roll our own implementation of delayed work now that we > have proper implementation of mod_delayed_work. > > For interrupt-only driven buttons we retain the timer, but we rename > it to release_timer to better reflect its purpose. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
What I want to do with this, on top of this, is to move debouncing to the GPIO subsystem. I want gpio(d)_set_debounce() to *always* work and the timer moved to gpiolib.c.
We can't have debouncing in every subsystem using GPIOs, it belongs in the GPIO core.
Yours, Linus Walleij
| |