lkml.org 
[lkml]   [2014]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter
Date
> (..)
> > +config GPIO_CYUSBS23X
> > + tristate "CYUSBS23x GPIO support"
> > + depends on MFD_CYUSBS23X && USB
>
> Doesn't MFD_CYUSV23X already depend on USB?

Yes, removed USB from GPIO and I2C

> > + if (gpio->out_gpio & (1 << offset))
> > + return gpio->out_value & (1 << offset);
>
> Rewrite like this:
>
> if (gpio->out_gpio & BIT(offset))
> return !!(gpio->out_value & BIT(offset));

Ok, updated for all instances.

Incorporated the comments and posted v5 patch.

Regards,
Muthu

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
\
 
 \ /
  Last update: 2014-12-13 13:21    [W:1.039 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site