Messages in this thread | | | Date | Sat, 13 Dec 2014 15:38:57 -0800 | Subject | Re: frequent lockups in 3.18rc4 | From | Linus Torvalds <> |
| |
On Sat, Dec 13, 2014 at 3:35 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > > Er... There's much more direct reason - suppose we get a timer interrupt > right in the middle of mnt_drop_write(). And lost the timeslice.
So?
You didn't have preemption disabled in *between* the mnt_want_write() and mnt_drop_write(), there's absolutely no reason to have it inside of them.
Nobody cares if you get preempted and go away for a while. It's exactly equivalent to sleeping while doing the write that the pair was protecting.
Seriously, the preemption disable looks like just voodoo code. It doesn't protect anything, it doesn't fix anything, it doesn't change anything. All it does is disable preemption over a random sequence of code.
Linus
| |