lkml.org 
[lkml]   [2014]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: rtl8723au: Fix sparse warnings
    Date
    Some struct fields in wifi.h are meant to be __le16 but were declared as
    unsigned short. This was reported by sparse:

    rtw_wlan_util.c:538:24: warning: cast to restricted __le16
    rtw_wlan_util.c:1544:29: warning: cast to restricted __le16
    rtw_wlan_util.c:1546:25: warning: cast to restricted __le16

    This patch changes the types of the struct fields involved to be
    little-endian which is what is received over the air and consistent with
    relevant structs in include/linux/ieee80211.h.

    Signed-off-by: Krzysztof Konopko <kris@konagma.com>
    ---
    drivers/staging/rtl8723au/include/wifi.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h
    index fd3da3b..266c43e 100644
    --- a/drivers/staging/rtl8723au/include/wifi.h
    +++ b/drivers/staging/rtl8723au/include/wifi.h
    @@ -28,7 +28,7 @@
    struct AC_param {
    unsigned char ACI_AIFSN;
    unsigned char CW;
    - unsigned short TXOP_limit;
    + __le16 TXOP_limit;
    } __packed;

    struct WMM_para_element {
    @@ -39,9 +39,9 @@ struct WMM_para_element {

    struct ADDBA_request {
    unsigned char dialog_token;
    - unsigned short BA_para_set;
    - unsigned short BA_timeout_value;
    - unsigned short BA_starting_seqctrl;
    + __le16 BA_para_set;
    + __le16 BA_timeout_value;
    + __le16 BA_starting_seqctrl;
    } __packed;


    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-13 00:41    [W:4.234 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site