Messages in this thread Patch in this message | | | From | Lai Jiangshan <> | Subject | [PATCH 1/5] workqueue: fix memory leak in wq_numa_init() | Date | Fri, 12 Dec 2014 18:19:51 +0800 |
| |
wq_numa_init() will quit directly on some bonkers cases without freeing the memory. Add the missing cleanup code.
Cc: Tejun Heo <tj@kernel.org> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Cc: "Gu, Zheng" <guz.fnst@cn.fujitsu.com> Cc: tangchen <tangchen@cn.fujitsu.com> Cc: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> --- kernel/workqueue.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 09b685d..a6fd2b8 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -4811,6 +4811,9 @@ static void __init wq_numa_init(void) if (WARN_ON(node == NUMA_NO_NODE)) { pr_warn("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu); /* happens iff arch is bonkers, let's just proceed */ + for_each_node(node) + free_cpumask_var(tbl[node]); + kfree(tbl); return; } cpumask_set_cpu(cpu, tbl[node]); -- 1.7.4.4
| |