Messages in this thread | | | Date | Thu, 11 Dec 2014 10:41:19 +0900 | From | Masahiro Yamada <> | Subject | Re: [PATCH] kbuild: fix scripts/headers.sh to see the correct Kbuild path |
| |
Hi Paul,
On Mon, 08 Dec 2014 22:58:33 +0100 Paul Bolle <pebolle@tiscali.nl> wrote:
> Masahiro, > > On Wed, 2014-12-03 at 15:52 +0900, Masahiro Yamada wrote: > > The exported headers were moved to "uapi" directories. > > We should check the existence of arch/*/include/uapi/asm/Kbuild. > > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > > --- > > Does this patch fix any problems? If so, which?
I am fixing a wrong code.
Actually, the "um" architecture does not support headers install.
arch/um/include/asm/Kbuild exists arch/um/include/uapi/asm/Kbuild does not exist
Checking arch/*/include/asm/Kbuild does not work.
Moreover, the top Makefile is checking arch/*/include/uapi/asm/Kbuild
headers_install: __headers $(if $(wildcard $(srctree)/arch/$(hdr-arch)/include/uapi/asm/Kbuild),, \ $(error Headers not exportable for the $(SRCARCH) architecture))
> And why did no one > notice these problems before? Perhaps the commit explanation could > mention that.
You will notice the code below:
for arch in ${archs}; do case ${arch} in um) # no userspace export ;;
"um" has already been omitted and it never reaches do_command(). That is why nobody has noticed this issue.
Uh, OK, we do not need double-checking.
Best Regards Masahiro Yamada
| |