lkml.org 
[lkml]   [2014]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] PCI: hotplug: Deletion of an unnecessary check before the function call "pci_dev_put"
    On Thu, Nov 20, 2014 at 05:47:29PM +0100, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Thu, 20 Nov 2014 17:42:23 +0100
    >
    > The pci_dev_put() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    Applied to next-pci/misc for v3.19, thanks. This branch will be rebased
    when v3.19-rc1 is released.

    Bjorn

    > ---
    > drivers/pci/hotplug/cpci_hotplug_core.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/pci/hotplug/cpci_hotplug_core.c b/drivers/pci/hotplug/cpci_hotplug_core.c
    > index e09cf78..82c969b 100644
    > --- a/drivers/pci/hotplug/cpci_hotplug_core.c
    > +++ b/drivers/pci/hotplug/cpci_hotplug_core.c
    > @@ -211,8 +211,7 @@ static void release_slot(struct hotplug_slot *hotplug_slot)
    >
    > kfree(slot->hotplug_slot->info);
    > kfree(slot->hotplug_slot);
    > - if (slot->dev)
    > - pci_dev_put(slot->dev);
    > + pci_dev_put(slot->dev);
    > kfree(slot);
    > }
    >
    > --
    > 2.1.3
    >


    \
     
     \ /
      Last update: 2014-12-11 01:41    [W:4.019 / U:1.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site