lkml.org 
[lkml]   [2014]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()
Date


> -----Original Message-----
> From: Jeremiah Mahler [mailto:jmmahler@gmail.com]
> Sent: Wednesday, December 10, 2014 1:46 PM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in
> vmbus_establish_gpadl()
>
> K. Y. Srinivasan,
>
> On Wed, Dec 10, 2014 at 12:29:19PM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in vmbus_establish_gpadl(). I would like to thank Michael
> > Brown <mcb30@ipxe.org> for seeing this bug.
> > In this version, I have added the Reported-by tag.
>
> The log message should be more specific. "Fix a bug" is too vague.
> Why is this patch necessary? What bug does it fix? What changes did you
> make?
>
> Saying you have "added the Reported-by tag" is not helpful in a log message.
> Although you can add notes for the patch reviewer under '---'.

Thank you; I will fix up the log and resend.

K. Y


\
 
 \ /
  Last update: 2014-12-11 01:41    [W:0.103 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site