Messages in this thread | | | Date | Wed, 10 Dec 2014 11:08:28 -0600 (CST) | From | Christoph Lameter <> | Subject | Re: [PATCH 3/7] slub: Do not use c->page on free |
| |
On Wed, 10 Dec 2014, Pekka Enberg wrote:
> > +static bool same_slab_page(struct kmem_cache *s, struct page *page, void *p) > > Why are you passing a pointer to struct kmem_cache here? You don't > seem to use it.
True. > > +{ > > + long d = p - page->address; > > + > > + return d > 0 && d < (1 << MAX_ORDER) && d < (compound_order(page) << PAGE_SHIFT); > > +} > > Can you elaborate on what this is doing? I don't really understand it.
Checks if the pointer points to the slab page. Also it tres to avoid having to call compound_order needlessly. Not sure if that optimization is worth it.
| |