Messages in this thread | | | Date | Wed, 10 Dec 2014 09:03:51 -0800 | From | John Fastabend <> | Subject | Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration |
| |
On 12/10/2014 08:50 AM, Jiri Pirko wrote: > Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varlese@intel.com wrote: >> From: Marco Varlese <marco.varlese@intel.com> >> >> Switch hardware offers a list of attributes that are configurable >> on a per port basis. >> This patch provides a mechanism to configure switch ports by adding >> an NDO for setting specific values to specific attributes. >> There will be a separate patch that extends iproute2 to call the >> new NDO. > > > What are these attributes? Can you give some examples. I'm asking > because there is a plan to pass generic attributes to switch ports > replacing current specific ndo_switch_port_stp_update. In this case, > bridge is setting that attribute. > > Is there need to set something directly from userspace or does it make > rather sense to use involved bridge/ovs/bond ? I think that both will be > needed.
+1
I think for many attributes it would be best to have both. The in kernel callers and netlink userspace can use the same driver ndo_ops.
But then we don't _require_ any specific bridge/ovs/etc module. And we may have some attributes that are not specific to any existing software module. I'm guessing Marco has some examples of these.
[...]
-- John Fastabend Intel Corporation
| |