Messages in this thread | | | Date | Wed, 10 Dec 2014 09:49:21 -0500 | From | Greg KH <> | Subject | Re: [PATCH] staging: lustre: Fix the warning messages about casting without __user macro |
| |
On Wed, Dec 10, 2014 at 07:09:59AM +0000, Al Viro wrote: > On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote: > > From: Shalin Mehta <shalinmehta85@gmail.com> > > > > This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the assigned value should be user space pointer with __user macro. Where as here, the __user macro isn't used while casting. > > ... and pointers are not user space ones at all. Which is to say, quit > messing with casts; it's not struct iovec. Proper fix is to replace > it here (and in almost all places throughout drivers/staging/lustre) with > struct kvec. And yes, such a patch had been sent. Still not applied, > AFAICS...
Yeah, it's in the merge window and I'll pick new staging patches back up when 3.19-rc1 is released.
thanks,
greg k-h
| |