lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/2] [media] mn88473: One function call less in mn88473_init() after error detection
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 1 Dec 2014 23:15:20 +0100

    The release_firmware() function was called by the mn88473_init() function even
    if a previous function call "request_firmware" failed.
    This implementation detail could be improved by the introduction of another
    jump label.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/staging/media/mn88473/mn88473.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c
    index 52180bb..a333744 100644
    --- a/drivers/staging/media/mn88473/mn88473.c
    +++ b/drivers/staging/media/mn88473/mn88473.c
    @@ -225,7 +225,7 @@ static int mn88473_init(struct dvb_frontend *fe)
    ret = request_firmware(&fw, fw_file, &client->dev);
    if (ret) {
    dev_err(&client->dev, "firmare file '%s' not found\n", fw_file);
    - goto err;
    + goto err_request_firmware;
    }

    dev_info(&client->dev, "downloading firmware from file '%s'\n",
    @@ -261,9 +261,10 @@ static int mn88473_init(struct dvb_frontend *fe)
    dev->warm = true;

    return 0;
    +
    err:
    release_firmware(fw);
    -
    +err_request_firmware:
    dev_dbg(&client->dev, "failed=%d\n", ret);
    return ret;
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-02 00:01    [W:4.213 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site