lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] [media] mn88473: Deletion of an unnecessary check before the function call "release_firmware"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 1 Dec 2014 22:55:29 +0100

    The release_firmware() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/staging/media/mn88473/mn88473.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c
    index 1659335..52180bb 100644
    --- a/drivers/staging/media/mn88473/mn88473.c
    +++ b/drivers/staging/media/mn88473/mn88473.c
    @@ -262,8 +262,7 @@ static int mn88473_init(struct dvb_frontend *fe)

    return 0;
    err:
    - if (fw)
    - release_firmware(fw);
    + release_firmware(fw);

    dev_dbg(&client->dev, "failed=%d\n", ret);
    return ret;
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-02 00:01    [W:4.021 / U:1.848 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site