lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 0/3] mtd: nand: gpmi: add proper raw access support
On Sun, Nov 30, 2014 at 07:10:27PM +0100, Boris Brezillon wrote:
> Hello,
>
> This series provides an implementation for raw accesses taking care of
> hidding the specific layout used by the GPMI controller.
>
> Best Regards,
>
> Boris
>
> Changes since v5:
> - rename gpmi_move_bits into gpmi_copy_bits
>
> Changes since v4:
> - fixed a few corner cases in gpmi_move_bits (tested it with:
> https://github.com/bbrezillon/gpmi-move-bits-test/blob/master/gpmi-move-bits-test.c)
> - add documentation and comments for the new gpmi functions
>
> Changes since v3:
> - add comments to the gpmi_move_bits function
> - extend raw read/write documentation
> - move last part of the raw_page_read function into a conditional block
>
> Changes since v2:
> - fixed a bug in gpmi_move_bits
> - add a raw_buffer field to be used when using raw access methods
> (experienced memory corruptions when directly using page_buffer_virt
> buffer)
> - add raw OOB access functions

Applied the series. Thanks!

Out of curiosity, what tests does gpmi-nand.c now pass/fail?

Also, is it time to yank / fixup some of these comments from
gpmi-nand.c?

...
* FIXME: The following paragraph is incorrect, now that there exist
* ecc.read_oob_raw and ecc.write_oob_raw functions.
*
* Since MTD assumes the OOB is not covered by ECC, there is no pair of
* ECC-based/raw functions for reading or or writing the OOB. The fact that the
* caller wants an ECC-based or raw view of the page is not propagated down to
* this driver.
*/

Brian


\
 
 \ /
  Last update: 2014-12-01 10:21    [W:0.073 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site