lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] block-rsxx: Deletion of an unnecessary check before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 1 Dec 2014 19:19:25 +0100

    The vfree() function performs also input parameter validation.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/block/rsxx/dma.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c
    index cf8cd29..0181387 100644
    --- a/drivers/block/rsxx/dma.c
    +++ b/drivers/block/rsxx/dma.c
    @@ -960,8 +960,7 @@ failed_dma_setup:
    ctrl->done_wq = NULL;
    }

    - if (ctrl->trackers)
    - vfree(ctrl->trackers);
    + vfree(ctrl->trackers);

    if (ctrl->status.buf)
    pci_free_consistent(card->dev, STATUS_BUFFER_SIZE8,
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-01 20:01    [W:4.016 / U:1.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site