lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 16/46] virtio_blk: v1.0 support
    > Based on patch by Cornelia Huck.
    >
    > Note: for consistency, and to avoid sparse errors,
    > convert all fields, even those no longer in use
    > for virtio v1.0.
    >
    > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ...
    >
    > -static unsigned int features[] = {
    > +static unsigned int features_legacy[] = {
    > VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY,
    > VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, VIRTIO_BLK_F_SCSI,
    > VIRTIO_BLK_F_WCE, VIRTIO_BLK_F_TOPOLOGY, VIRTIO_BLK_F_CONFIG_WCE,
    > VIRTIO_BLK_F_MQ,
    > +}
    > +;
    > +static unsigned int features[] = {
    > + VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY,
    > + VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE,
    > + VIRTIO_BLK_F_TOPOLOGY,
    > + VIRTIO_BLK_F_MQ,
    > + VIRTIO_F_VERSION_1,

    We can fit this into less lines, like done for features_legacy.

    I was asking myself if we could do the conversion of the statical values
    somehow upfront, to reduce the patch size and avoid cpu_to_virtio.* at those
    places.

    Otherwise looks good to me.




    \
     
     \ /
      Last update: 2014-12-01 10:01    [W:4.135 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site