Messages in this thread | | | Date | Sat, 8 Nov 2014 12:36:25 +0100 | From | Alban <> | Subject | Re: [PATCH 1/2] MIPS: FW: Fix parsing u-boot environment |
| |
On Fri, 07 Nov 2014 15:43:10 +0300 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> Hello. > > On 11/7/2014 2:23 PM, Alban Bedel wrote: > > > When reading u-boot's key=value pairs it should skip the '=' and not > > use the next argument. > > > Signed-off-by: Alban Bedel <albeu@free.fr> > > --- > > arch/mips/fw/lib/cmdline.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/arch/mips/fw/lib/cmdline.c b/arch/mips/fw/lib/cmdline.c > > index ffd0345..cc5d168 100644 > > --- a/arch/mips/fw/lib/cmdline.c > > +++ b/arch/mips/fw/lib/cmdline.c > > @@ -68,7 +68,7 @@ char *fw_getenv(char *envname) > > result = fw_envp(index + > > 1); break; > > } else if (fw_envp(index)[i] == > > '=') { > > - result = (fw_envp(index + > > 1) + i); > > + result = (fw_envp(index) + > > i + 1); > > Perhaps it's time to drop the useless outer parens?
I agree, I'm sending a new serie.
Alban
| |