Messages in this thread | | | Date | Fri, 07 Nov 2014 15:43:19 +0100 | From | Tomasz Nowicki <> | Subject | Re: [RFC PATCH 2/4] x86, acpi, pci: Isolate new PCI mmconfig entry insertion. |
| |
On 07.11.2014 15:09, Arnd Bergmann wrote: > On Friday 07 November 2014 14:27:54 Tomasz Nowicki wrote: >> Add special pci_mmcfg_insert_lock mutex since pci_mmcfg_lock was moved >> to common file. No functional changes. >> >> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org> >> > > What is the new lock protecting against? You no longer have a mutual > exclusion with the other code, which looks like it is a functional > change, and also incorrect. > > It also sounds like the code was broken after the first patch and > you need this one to make it compile again. You can't do that, and > instead need to change the locking rules first.
Oh, that's right! Sorry I will take a look again.
Tomasz
| |