lkml.org 
[lkml]   [2014]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.
On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote:

> + { TFA9879_MISC_STATUS, 0x0000 }, /* 0x15, read-only */

The fix here is the wrong way round - if the device is reporting status
here there should be no default and there should be a volatile operation
(though it's not the end of the world to omit that if it's not used).

Otherwise this looks good.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-07 13:01    [W:0.041 / U:24.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site