Messages in this thread | | | Date | Fri, 7 Nov 2014 11:17:37 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier. |
| |
On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote:
> + { TFA9879_MISC_STATUS, 0x0000 }, /* 0x15, read-only */
The fix here is the wrong way round - if the device is reporting status here there should be no default and there should be a volatile operation (though it's not the end of the world to omit that if it's not used).
Otherwise this looks good. [unhandled content-type:application/pgp-signature] | |