Messages in this thread |  | | Subject | Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities | From | Artem Bityutskiy <> | Date | Thu, 06 Nov 2014 10:18:45 +0200 |
| |
On Sun, 2014-11-02 at 19:14 +0200, Tanya Brokhman wrote: > >> + ubi_err(ubi, "self-check failed for PEB %d", pnum); > >> + ubi_msg(ubi, "hex dump of the %d-%d region", > >> + offset, offset + len); > >> print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1, buf, > len, 1); > >> err = -EINVAL; > >> error: > > > > Artem, I know you have tried to align the message code in different > lines, maybe > > you can check if you lose this one. > > > > hmmm... not sure I understand what is wrong here....
It is more of a nit-pick, but we try to be consistent. Here is how we align split messages:
ubi_msg(ubi, "blah", XYZ)
and not
ubi_msg(ubi, "blah", XYZ)
So we first use few tabs, and then some spaces to align. You use just tabs. Sometimes the second line is aligned, sometimes it goes a bit further.
|  |