| Subject | Re: [PATCH 08/35] UBI: Split __wl_get_peb() | From | Artem Bityutskiy <> | Date | Thu, 06 Nov 2014 09:51:46 +0200 |
| |
On Wed, 2014-10-29 at 13:45 +0100, Richard Weinberger wrote: > Make it two functions, wl_get_wle() and wl_get_peb(). > wl_get_peb() works exactly like __wl_get_peb() but wl_get_wle() > does not call produce_free_peb(). > While refilling the fastmap user pool we cannot release ubi->wl_lock > as produce_free_peb() does. > Hence the fastmap logic uses now wl_get_wle(). > > Signed-off-by: Richard Weinberger <richard@nod.at>
Please, re-consider naming.
The convention is that non-static function names start with ubi_wl_*. Static function names start with _*.
Also, please add a comment above the functions explaining what it does.
Artem.
|