Messages in this thread | | | Subject | Re: [PATCH] kconfig: Fix warning "‘jump’ may be used uninitialized" | From | Paul Bolle <> | Date | Thu, 06 Nov 2014 13:36:32 +0100 |
| |
On Thu, 2014-11-06 at 13:03 +0100, Peter Kümmel wrote: > Warning: > In file included from scripts/kconfig/zconf.tab.c:2537:0: > scripts/kconfig/menu.c: In function ‘get_symbol_str’: > scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] > jump->offset = strlen(r->s); > > Simplifies the test logic because (head && local) means (jump != 0) > and makes GCC happy when checking if the jump pointer was initialized. > > Signed-off-by: Peter Kümmel <syntheticpp@gmx.net> > ---
Is this patch and the three others patches you just sent identical (or not) to the four patches you sent yesterday and the day before yesterday to linux-kbuild and Yann Morin? Either way, why are you posting them to lkml now?
> scripts/kconfig/menu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c > index a26cc5d..72c9dba 100644 > --- a/scripts/kconfig/menu.c > +++ b/scripts/kconfig/menu.c > @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, > { > int i, j; > struct menu *submenu[8], *menu, *location = NULL; > - struct jump_key *jump; > + struct jump_key *jump = NULL; > > str_printf(r, _("Prompt: %s\n"), _(prop->text)); > menu = prop->menu->parent; > @@ -586,7 +586,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, > str_printf(r, _(" Location:\n")); > for (j = 4; --i >= 0; j += 2) { > menu = submenu[i]; > - if (head && location && menu == location) > + if (jump && menu == location) > jump->offset = strlen(r->s); > str_printf(r, "%*c-> %s", j, ' ', > _(menu_get_prompt(menu)));
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |