Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH v3 2/3] perf: Userspace event | Date | Wed, 05 Nov 2014 15:36:31 +0900 |
| |
Hi Peter and Pawel,
On Tue, 4 Nov 2014 19:40:31 +0100, Peter Zijlstra wrote: > On Tue, Nov 04, 2014 at 04:42:11PM +0000, Pawel Moll wrote: >> >> 1. I'm wrong and the record doesn't have to be padded to make it 8 bytes >> aligned. Then I can drop the additional size field. > > No, you're right, we're supposed to stay 8 byte aligned. > >> 2. I could impose a limitation on the prctl API that the data size must >> be 8 bytes aligned. Bad idea in my opinion, I'd rather not. > > Agreed. > >> 3. The additional size (for the data part) field stays. Notice that >> PERF_SAMPLE_RAW has it as well :-) > > Right, with binary data there is no other day. With \0 terminated > strings there won't be a problem, but I think we decided we wanted to > allow any binary blow.
Ah, I missed that. Thank you guys for explanation.
Thanks, Namhyung
| |