lkml.org 
[lkml]   [2014]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:sched/core] sched/wait: Reimplement wait_event_freezable()
Hi!

> Commit-ID: 36df04bc5273a046f53b5e359febc1225f85aa7b
> Gitweb: http://git.kernel.org/tip/36df04bc5273a046f53b5e359febc1225f85aa7b
> Author: Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Wed, 29 Oct 2014 12:21:57 +0100
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 4 Nov 2014 07:17:45 +0100
>
> sched/wait: Reimplement wait_event_freezable()
>
> Provide better implementations of wait_event_freezable() APIs.
>
> The problem is with freezer_do_not_count(), it hides the thread from
> the freezer, even though this thread might not actually freeze/sleep
> at all.

Can you elaborate?

The thread will be in freezer_do_not_count() area, but it is just
waiting for event there, it should not do much damage.

If this is bugfix, should it be cc-ed to stable?

Did you test it with suspend/hibernation? Because I can't really see
how it works.

> +#define __wait_event_freezable(wq, condition) \
> + ___wait_event(wq, condition, TASK_INTERRUPTIBLE, 0, 0, \
> + schedule(); try_to_freeze())
> +

_Three_ underscores. And two underscore version exists, too,
fortunately it at least has different number of arguments.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-11-04 21:41    [W:0.065 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site