lkml.org 
[lkml]   [2014]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] clk: sunxi: Add support for sun9i a80 usb clocks and resets
    On Tue, Nov 04, 2014 at 12:07:14PM +0800, Chen-Yu Tsai wrote:
    > + spin_lock_irqsave(data->lock, flags);
    > +
    > + reg = readl(data->reg);
    > + writel(reg & ~BIT(id), data->reg);
    > +
    > + spin_unlock_irqrestore(data->lock, flags);

    Don't we have generic support for atomic modification of register
    values? Hmm, we have it for ARM only - atomic_io_modify() and
    atomic_io_modify_relaxed().

    I guess we should push for those to become cross-arch if we end up
    with generic drivers shared between other architectures.

    --
    FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
    according to speedtest.net.


    \
     
     \ /
      Last update: 2014-11-04 19:21    [W:4.527 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site