Messages in this thread | | | Date | Tue, 4 Nov 2014 14:52:22 +0000 | From | Al Viro <> | Subject | Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter |
| |
On Tue, Nov 04, 2014 at 10:44:16PM +0800, Herbert Xu wrote: > On Tue, Nov 04, 2014 at 02:35:36PM +0000, Al Viro wrote: > > On Tue, Nov 04, 2014 at 02:32:00PM +0000, Al Viro wrote: > > > > > Too noisy, IMO. How about skb_copy_datagram_msg() first? The fewer > > > places have to even think of iovec or iov_iter, the better... > > > > PS: "too noisy" is about turning every callsite of skb_copy_datagram_iovec > > into that of skb_copy_datagram_iter; the helper itself is just fine. > > Hmm if that is your concern then I don't see how skb_copy_datagram_msg > changes things as you'd still have to convert every existing caller > of skb_copy_datagram_iovec. Colour me confused.
Fewer places having to even think of iovec/iov_iter...
| |