Messages in this thread | | | Date | Tue, 4 Nov 2014 14:29:09 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform |
| |
On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote: > From: Andy yan <andy.yan@rock-chips.com> > > We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) > use the interface compatible Designware HDMI IP, but they also have some > lightly difference, such as phy pll configuration, register width(imx hdmi > register is one byte, but rk3288 is 4 bytes width and can only access by word), > 4K support(imx6 doesn't support 4k, but rk3288 does). > > To reuse the imx-hdmi driver, we do this patch set: > patch (1): split out imx-soc code from imx-hdmi to dw_hdmi-imx.c > patch (2): move imx-hdmi to bridge/, and rename to dw-hdmi to > make this driver indepent of drm-imx . And we will add rockchip > platform specific code dw_hdmi-rockchip.c later, this is depend > on drm-rockchip.
Great - I fully agree that this needs to be renamed as it is a Designware IP.
Should it be moved into bridge/ ? It isn't implemented as a DRM bridge driver at present, so this seems illogical. Is the longer term plan to convert it to be a DRM bridge?
Secondly, if you want HDMI audio support, you may find the patches I maintain for the SolidRun devices useful, which add this as a standard ALSA device. I also have CEC support for it as well. If you're interested, I'll email those.
-- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
| |