Messages in this thread | | | Date | Tue, 4 Nov 2014 09:22:40 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work. |
| |
Hello, Neil.
Sorry about the delay.
On Thu, Oct 30, 2014 at 10:19:32AM +1100, NeilBrown wrote: > > Given that workder depletion is pool-wide > > event, maybe it'd make sense to trigger rescuers immediately while > > workers are in short supply? e.g. while there's a manager stuck in > > maybe_create_worker() with the mayday timer already triggered? > > So what if I change "need_more_worker" to "need_to_create_worker" ? > Then it will stop as soon as there in an idle worker thread. > That is the condition that keeps maybe_create_worker() looping. > ??
Yeah, that'd be a better condition and can work out. Can you please write up a patch to do that and do some synthetic tests excercising the code path? Also please cc Lai Jiangshan <laijs@cn.fujitsu.com> when posting the patch.
Thanks.
-- tejun
| |