lkml.org 
[lkml]   [2014]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [char-misc-next V3] mei: add reference counting for me clients
Date
> 
> On Mon, Nov 03, 2014 at 10:42:05AM +0200, Tomas Winkler wrote:
> > To support dynamic addition/remove we add reference
> > counter.
>
> What is keeping two different threads / cpus from grabbing a reference
> at the same time the other one is dropping it?
>
> You have a list here, with no locking, right? You also don't have any
> locking for your kref, which isn't good at all...
>
> Please audit and fix up.

Of course there is a lock, it wouldn't work at all. It is not explicit but we run under device_lock mutex.

Tomas



\
 
 \ /
  Last update: 2014-11-04 07:01    [W:0.065 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site