Messages in this thread | | | Date | Tue, 4 Nov 2014 11:01:41 +0100 | From | Jan Kara <> | Subject | Re: [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it |
| |
On Tue 04-11-14 10:52:58, Christoph Hellwig wrote: > On Wed, Oct 22, 2014 at 10:14:11PM +0200, Jan Kara wrote: > > Currently i_cdev reference to a character device isn't accounted in the > > reference count of the character device. This then requires us to track > > all references through a list of all inodes referencing a character > > device which is somewhat clumsy and requires list_head in each inode in > > the system. > > > > So make i_cdev a reference like any other. > > Looks good. > > Reviewed-by: Christoph Hellwig <hch@lst.de> Thanks for review.
> Maybe you can rename the new variable to something like to_put also? Yes, that's better. Done.
Honza
-- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |