Messages in this thread | | | Date | Tue, 4 Nov 2014 10:42:15 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/4] blockdev: Don't use i_devices inode field |
| |
On Wed, Oct 22, 2014 at 10:14:10PM +0200, Jan Kara wrote: > Block devices use i_devices inode field to track all inodes that > reference a particular block device (through i_bdev field) so that this > reference can be removed when block device inode is being evicted from > memory. However we get a reference to the block device (in fact an inode > holding the block device structure) when setting up i_bdev in > bd_acquire() and we drop the reference only in bd_forget() when clearing > i_bdev. Thus inode holding block device structure can be evicted only > after all inodes referencing it are evicted and the whole excercise with > i_devices is pointless. Remove the i_devices handling. > > Signed-off-by: Jan Kara <jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |