Messages in this thread | | | Date | Sun, 30 Nov 2014 13:23:48 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/2] kernel: add support for live patching |
| |
On Thu 2014-11-06 16:51:02, Jiri Slaby wrote: > On 11/06/2014, 03:39 PM, Seth Jennings wrote: > > This commit introduces code for the live patching core. It implements > > an ftrace-based mechanism and kernel interface for doing live patching > > of kernel and kernel module functions. > > Hi, > > nice! So we have something to start with. Brilliant! > > I have some comments below now. Yet, it obviously needs deeper review > which will take more time. > > > --- /dev/null > > +++ b/include/linux/livepatch.h > > @@ -0,0 +1,45 @@ > > +#ifndef _LIVEPATCH_H_ > > +#define _LIVEPATCH_H_ > > This should follow the linux kernel naming: LINUX_LIVEPATCH_H > > > > +#include <linux/module.h> > > + > > +struct lp_func { > > I am not much happy with "lp" which effectively means parallel printer > support. What about lip?
What about "patch_"?
It is not so big subsystem that additional typing would matter much...
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |