lkml.org 
[lkml]   [2014]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] [media] V4L2: Deletion of an unnecessary check before the function call "vb2_put_vma"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 30 Nov 2014 23:10:51 +0100

    The vb2_put_vma() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/v4l2-core/videobuf2-vmalloc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c
    index 3966b12..fba944e 100644
    --- a/drivers/media/v4l2-core/videobuf2-vmalloc.c
    +++ b/drivers/media/v4l2-core/videobuf2-vmalloc.c
    @@ -154,8 +154,7 @@ static void vb2_vmalloc_put_userptr(void *buf_priv)
    }
    kfree(buf->pages);
    } else {
    - if (buf->vma)
    - vb2_put_vma(buf->vma);
    + vb2_put_vma(buf->vma);
    iounmap(buf->vaddr);
    }
    kfree(buf);
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-01 00:01    [W:4.021 / U:1.644 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site