Messages in this thread Patch in this message | | | Date | Sun, 30 Nov 2014 23:23:17 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] [media] V4L2: Deletion of an unnecessary check before the function call "vb2_put_vma" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 30 Nov 2014 23:10:51 +0100
The vb2_put_vma() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/v4l2-core/videobuf2-vmalloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c index 3966b12..fba944e 100644 --- a/drivers/media/v4l2-core/videobuf2-vmalloc.c +++ b/drivers/media/v4l2-core/videobuf2-vmalloc.c @@ -154,8 +154,7 @@ static void vb2_vmalloc_put_userptr(void *buf_priv) } kfree(buf->pages); } else { - if (buf->vma) - vb2_put_vma(buf->vma); + vb2_put_vma(buf->vma); iounmap(buf->vaddr); } kfree(buf); -- 2.1.3
| |