Messages in this thread | | | Date | Sun, 30 Nov 2014 01:01:06 -0800 | From | Brian Norris <> | Subject | Re: [PATCH v4 2/2] mtd: hisilicon: add device tree binding documentation |
| |
One more thing:
On Tue, Nov 04, 2014 at 08:47:01PM +0800, Zhou Wang wrote: > diff --git a/Documentation/devicetree/bindings/mtd/hisi504-nand.txt b/Documentation/devicetree/bindings/mtd/hisi504-nand.txt > new file mode 100644 > index 0000000..c8b3988 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/hisi504-nand.txt > @@ -0,0 +1,40 @@ > +Hisilicon Hip04 Soc NAND controller DT binding > + > +Required properties: > +- compatible: Should be "hisilicon,504-nfc".
I notice you use "NFC" naming throughout. I know others have had complaints about overloading the acronym NFC which sometimes means "Near Field Communication", instead of the intended "NAND Flash Controller." Is there any kind of naming convention within Hisilicon documentation that insists on calling this NFC, or can we avoid that confusing name?
If possible, I'd suggest "hisilicon,504-nand" as an alternative.
Brian
| |