Messages in this thread | | | Date | Tue, 4 Nov 2014 09:10:46 +0800 | From | Tang Chen <> | Subject | Re: [PATCH 0/2] Fix node meminfo corruption. |
| |
Hi all,
I thinks these two problems are very important and should be merged ASAP. Would you please help to have a look at it ?
Thanks.
On 10/31/2014 05:46 PM, Tang Chen wrote: > There are two problems when calculating node meminfo: > > 1. When hot-adding a node without onlining any page, MemTotal corrupted. > > # hot-add node2 (memory not onlined) > # cat /sys/device/system/node/node2/meminfo > Node 2 MemTotal: 33554432 kB /* corrupted */ > Node 2 MemFree: 0 kB > Node 2 MemUsed: 33554432 kB > Node 2 Active: 0 kB > ...... > > > 2. When onlining memory on node2, MemFree of node3 corrupted. > > # for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done > # cat /sys/devices/system/node/node2/meminfo > Node 2 MemTotal: 33554432 kB > Node 2 MemFree: 33549092 kB > Node 2 MemUsed: 5340 kB > ...... > # cat /sys/devices/system/node/node3/meminfo > Node 3 MemTotal: 0 kB > Node 3 MemFree: 248 kB /* corrupted */ > Node 3 MemUsed: 0 kB > ...... > > This patch-set fixes them. > > Tang Chen (2): > mem-hotplug: Reset node managed pages when hot-adding a new pgdat. > mem-hotplug: Fix wrong check for zone->pageset initialization in > online_pages(). > > include/linux/bootmem.h | 1 + > include/linux/mm.h | 1 + > mm/bootmem.c | 9 +++++---- > mm/memory_hotplug.c | 15 ++++++++++++++- > mm/nobootmem.c | 8 +++++--- > mm/page_alloc.c | 5 +++++ > 6 files changed, 31 insertions(+), 8 deletions(-) >
| |