lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/asm] sched/x86_64: Don't save flags on context switch
Argh, sorry for confusion...

On 11/03, Andy Lutomirski wrote:
>
> On Mon, Nov 3, 2014 at 1:58 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 11/03, Oleg Nesterov wrote:
> >>
> > Btw, why retint_kernel() checks "interrupts on" ? It seems to me that
> > that "interrupts off" is not possible, no? And this will be more clear
> > when we remove the "exit_intr" label.
>
> We might get there from #MC or from any of a number of synchronous
> errors (#GP from xyz_safe, #PF from some atomic uaccess thing or a
> vmap fault, etc), and all of those have interrupts off.

Yes, yes, exactly.

I actually tried to say that irqs should be always disabled (afaics!).
IOW "interrupts on" should not be possible, not "interrupts off".

Oleg.



\
 
 \ /
  Last update: 2014-11-04 00:01    [W:0.051 / U:1.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site